cloud-fan commented on code in PR #45592:
URL: https://github.com/apache/spark/pull/45592#discussion_r1538483034
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -638,7 +641,38 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
parameters = Map(
"fieldName" -> "c2",
"expressionStr" -> "UCASE(struct1.a)",
- "reason" -> "generation expression cannot contain non-default collated
string type"))
+ "reason" ->
+ "generation expression cannot contain non-binary orderable collated
string type"))
+ }
+
+ test("SPARK-47431: Default collation set to UNICODE, literal test") {
+ withSQLConf(SqlApiConf.DEFAULT_COLLATION -> "UNICODE") {
+ checkAnswer(sql(s"SELECT collation('aa')"), Seq(Row("UNICODE")))
+ }
+ }
+
+ test("SPARK-47431: Default collation set to UNICODE, column type test") {
+ withSQLConf(SqlApiConf.DEFAULT_COLLATION -> "UNICODE") {
+ sql(
+ s"""
+ |CREATE TABLE t(c1 STRING)
+ |USING PARQUET
+ |""".stripMargin)
+ sql("INSERT INTO t VALUES ('a')")
+ checkAnswer(sql("SELECT collation(c1) FROM t"), Seq(Row("UNICODE")))
+ }
+ }
+
+ test("SPARK-47431: Create table with UTF8_BINARY, make sure collation
persists on read") {
+ sql(
+ s"""
+ |CREATE TABLE t(c1 STRING)
+ |USING PARQUET
+ |""".stripMargin)
+ sql("INSERT INTO t VALUES ('a')")
+ checkAnswer(sql("SELECT collation(c1) FROM t"), Seq(Row("UTF8_BINARY")))
+ sql("SET spark.sql.session.collation.default=UNICODE")
Review Comment:
use `withSQLConf` to set conf in test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
