cloud-fan commented on code in PR #45592: URL: https://github.com/apache/spark/pull/45592#discussion_r1538482045
########## sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala: ########## @@ -493,7 +493,7 @@ private[columnar] trait DirectCopyColumnType[JvmType] extends ColumnType[JvmType } private[columnar] object STRING - extends NativeColumnType(PhysicalStringType(CollationFactory.DEFAULT_COLLATION_ID), 8) + extends NativeColumnType(PhysicalStringType(SqlApiConf.get.defaultStringType.collationId), 8) Review Comment: Do we need to change this? It looks this object does not care about collation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
