cloud-fan commented on code in PR #45383:
URL: https://github.com/apache/spark/pull/45383#discussion_r1546284265
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -28,6 +28,7 @@ import org.apache.spark.sql.catalyst.util.CollationFactory
*/
@Stable
class StringType private(val collationId: Int) extends AtomicType with
Serializable {
+ var isExplicit: Boolean = false
Review Comment:
why isn't it part of construct parameters?
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -28,6 +28,7 @@ import org.apache.spark.sql.catalyst.util.CollationFactory
*/
@Stable
class StringType private(val collationId: Int) extends AtomicType with
Serializable {
+ var isExplicit: Boolean = false
Review Comment:
why isn't it part of constructor parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
