uros-db commented on code in PR #46041: URL: https://github.com/apache/spark/pull/46041#discussion_r1568699474
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -1573,8 +1573,10 @@ case class StringLPad(str: Expression, len: Expression, pad: Expression) override def second: Expression = len override def third: Expression = pad - override def dataType: DataType = str.dataType - override def inputTypes: Seq[AbstractDataType] = Seq(StringType, IntegerType, StringType) + override def dataType: DataType = CollationTypeCasts.getOutputCollation(Seq(str, pad)) Review Comment: you need to add your expressions to `CollationTypeCasts` in order for implicit casting to work check out this PR: https://github.com/apache/spark/pull/46003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
