GideonPotok commented on PR #46041:
URL: https://github.com/apache/spark/pull/46041#issuecomment-2063189619
@uros-db Done: I added tests for implicit cast. Note that since I follow the
pattern for tests for Contains/StartsWith/EndsWith, the part of the test that
validates behavior of implicit cast, uses `checkAnswer` but does not check
type... For predicates such as Contains/StartsWith/EndsWith, this makes good
sense, as if the cast was not correct, the result would be a different boolean
value then expected.
For testing not predicate functions, the pattern makes less sense to me and
might benefit for the addition of checking the return type, in my opinion. This
would be a departure from the pattern. Let me know what you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
