GideonPotok commented on code in PR #46041: URL: https://github.com/apache/spark/pull/46041#discussion_r1568687405
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -1573,8 +1573,10 @@ case class StringLPad(str: Expression, len: Expression, pad: Expression) override def second: Expression = len override def third: Expression = pad - override def dataType: DataType = str.dataType - override def inputTypes: Seq[AbstractDataType] = Seq(StringType, IntegerType, StringType) + override def dataType: DataType = CollationTypeCasts.getOutputCollation(Seq(str, pad)) Review Comment: @uros-db i am not getting an exception by default. Seems collationTypeCast is not trying to cast these to the same type. Please advise. I could override checkInputDataTypes as an alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
