HyukjinKwon commented on code in PR #46147:
URL: https://github.com/apache/spark/pull/46147#discussion_r1573486776
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -385,13 +386,15 @@ public UTF8String toUpperCase() {
}
private UTF8String toUpperCaseSlow() {
- return fromString(toString().toUpperCase());
+ return fromString(toString().toUpperCase(Locale.ROOT));
Review Comment:
I think we shouldn't apply locale when we handle actual data. My take is
that the upper lower cases should be locale dependent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
