panbingkun commented on code in PR #46147:
URL: https://github.com/apache/spark/pull/46147#discussion_r1574422834


##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java:
##########
@@ -171,7 +172,7 @@ public void runInternal() throws HiveSQLException {
           List<SQLPrimaryKey> primaryKeys = metastoreClient.getPrimaryKeys(new 
PrimaryKeysRequest(dbName, table.getTableName()));
           Set<String> pkColNames = new HashSet<>();
           for(SQLPrimaryKey key : primaryKeys) {
-            pkColNames.add(key.getColumn_name().toLowerCase());
+            pkColNames.add(key.getColumn_name().toLowerCase(Locale.ROOT));

Review Comment:
   Done



##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -385,13 +386,15 @@ public UTF8String toUpperCase() {
   }
 
   private UTF8String toUpperCaseSlow() {
-    return fromString(toString().toUpperCase());
+    return fromString(toString().toUpperCase(Locale.ROOT));

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to