dongjoon-hyun commented on code in PR #46147:
URL: https://github.com/apache/spark/pull/46147#discussion_r1575043463
##########
dev/checkstyle.xml:
##########
@@ -196,6 +196,17 @@
<property name="format" value="@Test\(expected"/>
<property name="message" value="Please use the `assertThrows`
method to test for exceptions." />
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="id" value="caselocale" />
+ <property name="format"
value="(\.toUpperCase|\.toLowerCase)((\(\))|(?!(\w|\(|\(Locale.ROOT\))))"/>
+ <property name="message"
+ value="\nAre you sure that you want to use toUpperCase or
toLowerCase without the root locale? In most cases, you should use
toUpperCase(Locale.ROOT) or toLowerCase(Locale.ROOT) instead.\n
+ If you must use toUpperCase or toLowerCase without the root locale, wrap
the code block with\n
+ // checkstyle.off: RegexpSinglelineJava\n
+ .toUpperCase\n
+ .toLowerCase\n
+ // checkstyle.off: RegexpSinglelineJava" />
Review Comment:
I believe we can remove line 204 ~ 208.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
