09306677806 commented on PR #46041: URL: https://github.com/apache/spark/pull/46041#issuecomment-2068216025
U;Sh(7700077)SQL HARMAN 04#G) ShahrzadMahro در تاریخ دوشنبه ۲۲ آوریل ۲۰۲۴، ۰۱:۲۴ Gideon Potok ***@***.***> نوشت: > ***@***.**** commented on this pull request. > ------------------------------ > > In > sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala > <https://github.com/apache/spark/pull/46041#discussion_r1573929256>: > > > + case stringRPad: StringRPad => > + val Seq(str, pad) = collateToSingleType(Seq(stringRPad.str, stringRPad.pad)) > + stringRPad.withNewChildren(Seq(str, stringRPad.len, pad)) > + > + case stringLPad: StringLPad => > + val Seq(str, pad) = collateToSingleType(Seq(stringLPad.str, stringLPad.pad)) > + stringLPad.withNewChildren(Seq(str, stringLPad.len, pad)) > > @uros-db <https://github.com/uros-db> done. please re-review. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/46041#discussion_r1573929256>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANEZZRCQABGMZCVIUQIHFWDY6QYQ7AVCNFSM6AAAAABGGDLKUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGUZDQOJSGY> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
