uros-db commented on code in PR #46041:
URL: https://github.com/apache/spark/pull/46041#discussion_r1573905109
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -52,6 +52,14 @@ object CollationTypeCasts extends TypeCoercionRule {
overlay.withNewChildren(collateToSingleType(Seq(overlay.input,
overlay.replace))
++ Seq(overlay.pos, overlay.len))
+ case stringRPad: StringRPad =>
+ val Seq(str, pad) = collateToSingleType(Seq(stringRPad.str,
stringRPad.pad))
+ stringRPad.withNewChildren(Seq(str, stringRPad.len, pad))
+
+ case stringLPad: StringLPad =>
+ val Seq(str, pad) = collateToSingleType(Seq(stringLPad.str,
stringLPad.pad))
+ stringLPad.withNewChildren(Seq(str, stringLPad.len, pad))
Review Comment:
it would be good if we could combine these, like you did before
try if something like this works:
```
val Seq(str, len, pad) = stringPadExpr.children
val Seq(newStr, newPad) = collateToSingleType(Seq(str, pad))
stringPadExpr.withNewChildren(Seq(newStr, len, newPad))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
