uros-db commented on code in PR #46041:
URL: https://github.com/apache/spark/pull/46041#discussion_r1573839675
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -52,6 +52,12 @@ object CollationTypeCasts extends TypeCoercionRule {
overlay.withNewChildren(collateToSingleType(Seq(overlay.input,
overlay.replace))
++ Seq(overlay.pos, overlay.len))
+ case stringPadExpr@(_: StringLPad | _: StringRPad) =>
+ val newChildren = collateToSingleType(
+ Seq(stringPadExpr.children.head, stringPadExpr.children(2)))
+ stringPadExpr.withNewChildren(
+ Seq(newChildren.head, stringPadExpr.children(1), newChildren(1)))
Review Comment:
```suggestion
val Seq(str, pad) = collateToSingleType(Seq(stringLPad.str,
stringLPad.pad))
stringLPad.withNewChildren(Seq(str, stringLPad.len, pad))
```
Spark expressions have parameter names, so we might as well use them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
