uros-db commented on code in PR #46206: URL: https://github.com/apache/spark/pull/46206#discussion_r1578910474
########## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ########## Review Comment: this doesn't look good please follow the guides set out in https://issues.apache.org/jira/browse/SPARK-47410 regarding the latest refactor, and try to follow the structure of other string expressions (i.e. Contains, StartsWith, EndsWith) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
