uros-db commented on code in PR #46206: URL: https://github.com/apache/spark/pull/46206#discussion_r1578913462
########## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ########## Review Comment: I know that we're trying to push all collation aware changes away from UTF8String, and into CollationSupport.CollationAwareUTF8String but we should be careful about changing access modifiers here, adding @cloud-fan to take a look and advise on what's the preferred approach: 1. modify access in UTF8String in order to allow collation-aware implementation in CollationSupport 2. fall back to putting everything in UTF8String, instead of using CollationSupport.CollationAwareUTF8String -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
