davidm-db commented on code in PR #46206: URL: https://github.com/apache/spark/pull/46206#discussion_r1579018663
########## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ########## Review Comment: Well, other methods like `numBytes` and `getBytes` are already exposed publicly. These methods seem as "important" and "risky" as the methods I changed. The methods I changed also don't modify anything, they are either helpers or they access some information that is already exposed through `numBytes` or `getBytes`. That was my reasoning, but let's wait for @cloud-fan to provide his thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
