Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6512#discussion_r31376234
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala ---
@@ -277,8 +277,8 @@ private[spark] class RestSubmissionClient(master:
String) extends Logging {
private def getBaseUrl(master: String): String = {
var masterUrl = master
supportedMasterPrefixes.foreach { prefix =>
- if (master.startsWith(prefix)) {
- masterUrl = master.stripPrefix(prefix)
+ if (masterUrl.startsWith(prefix)) {
+ masterUrl = masterUrl.stripPrefix(prefix)
--- End diff --
Actually, why is this an issue? If we assume that the master URL matches
only one of the `supportedMasterPrefixes`, then this change doesn't actually do
anything, since we set `masterUrl = master` up there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
