Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6512#discussion_r31376509
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/RestSubmissionClient.scala ---
@@ -277,8 +277,8 @@ private[spark] class RestSubmissionClient(master:
String) extends Logging {
private def getBaseUrl(master: String): String = {
var masterUrl = master
supportedMasterPrefixes.foreach { prefix =>
- if (master.startsWith(prefix)) {
- masterUrl = master.stripPrefix(prefix)
+ if (masterUrl.startsWith(prefix)) {
+ masterUrl = masterUrl.stripPrefix(prefix)
--- End diff --
So the problem is that the master URL is being prepended with spark://, so
mesos://1.1.1.1 becomes spark://mesos://1.1.1.1, and therefore just stripping
it once doesn't work. While driving back home I realize this fix is not the
right fix, I should actually fix where the append is happening which is up
where master variable is being assigned. I'll create a new pr and jira against
master.
How do I then get a or against master into 1.4 branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
