uros-db commented on code in PR #46511:
URL: https://github.com/apache/spark/pull/46511#discussion_r1599873181
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:
##########
@@ -102,20 +102,30 @@ public void testContains() throws SparkException {
assertContains("äbćδe", "ÄbćδE", "UNICODE_CI", true);
assertContains("äbćδe", "ÄBcΔÉ", "UNICODE_CI", false);
// Case-variable character length
- assertContains("abİo12", "i̇o", "UNICODE_CI", true);
- assertContains("abi̇o12", "İo", "UNICODE_CI", true);
- assertContains("the İodine", "the i̇odine", "UTF8_BINARY_LCASE", true);
- assertContains("the i̇odine", "the İodine", "UTF8_BINARY_LCASE", true);
- assertContains("The İodiNe", " i̇oDin", "UTF8_BINARY_LCASE", true);
- assertContains("İodiNe", "i̇oDine", "UTF8_BINARY_LCASE", true);
- assertContains("İodiNe", " i̇oDin", "UTF8_BINARY_LCASE", false);
- // Characters with the same binary lowercase representation
- assertContains("The Kelvin.", "Kelvin", "UTF8_BINARY_LCASE", true);
- assertContains("The Kelvin.", "Kelvin", "UTF8_BINARY_LCASE", true);
- assertContains("The KKelvin.", "KKelvin", "UTF8_BINARY_LCASE", true);
- assertContains("2 Kelvin.", "2 Kelvin", "UTF8_BINARY_LCASE", true);
- assertContains("2 Kelvin.", "2 Kelvin", "UTF8_BINARY_LCASE", true);
- assertContains("The KKelvin.", "KKelvin,", "UTF8_BINARY_LCASE", false);
Review Comment:
added these back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
