uros-db commented on code in PR #46511:
URL: https://github.com/apache/spark/pull/46511#discussion_r1600495650
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -183,6 +204,19 @@ public static int findInSet(final UTF8String match, final
UTF8String set, int co
return 0;
}
+ public static int lowercaseIndexOf(final UTF8String target, final UTF8String
pattern,
+ final int start) {
+ if (pattern.numChars() == 0) return 0;
Review Comment:
why do you think it would not be expected? `indexOf` uses 0-based index
- -1 means "not found"
- 0 means "found at beginning"
an empty pattern string is (by definition) found at the beginning of any
given target string
I don't think there are any issues there - seems pretty expected to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
