panbingkun commented on code in PR #46782:
URL: https://github.com/apache/spark/pull/46782#discussion_r1620567944
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala:
##########
@@ -88,7 +88,7 @@ private[deploy] class SparkSubmitArguments(args: Seq[String],
env: Map[String, S
/** Default properties present in the currently defined defaults file. */
lazy val defaultSparkProperties: HashMap[String, String] = {
val defaultProperties = new HashMap[String, String]()
- if (verbose) {
+ if (verbose && propertiesFile != null) {
Review Comment:
When there is a `spark-defaults.conf` file in the conf dir
A.Original logic:
- If `propertiesFile` is `not` specified, it will print:
```
Using properties file: ... spark-defaults.conf
```
- If `propertiesFile` is specified, it will print:
```
Using properties file: ... xxx.properties
```
B.Current logic:
- If `propertiesFile` is not specified, will print nothing
- If `propertiesFile` is specified, it will print:
```
Using properties file: ... xxx.properties
```
It seems that the logic is `inconsistent` with the logic before this PR
https://github.com/apache/spark/pull/46709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
