advancedxy commented on code in PR #46782:
URL: https://github.com/apache/spark/pull/46782#discussion_r1621851009


##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala:
##########
@@ -548,6 +543,8 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         |  --conf, -c PROP=VALUE       Arbitrary Spark configuration property.
         |  --properties-file FILE      Path to a file from which to load extra 
properties. If not
         |                              specified, this will look for 
conf/spark-defaults.conf.
+        |  --extra-properties-files    Whether to load properties from 
conf/spark-defaults.conf,

Review Comment:
   I see. It's indeed sufficient to use a flag instead. 
   
   However, I think the flag name might be improved, maybe something like 
`--load-spark-defaults`? The previous flag name seems like it requires an 
additional FILE argument.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to