advancedxy commented on code in PR #46782:
URL: https://github.com/apache/spark/pull/46782#discussion_r1621793784


##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala:
##########
@@ -548,6 +543,8 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         |  --conf, -c PROP=VALUE       Arbitrary Spark configuration property.
         |  --properties-file FILE      Path to a file from which to load extra 
properties. If not
         |                              specified, this will look for 
conf/spark-defaults.conf.
+        |  --extra-properties-files    Whether to load properties from 
conf/spark-defaults.conf,

Review Comment:
   How about:
   ```
   --properties-file FILE           Path to a file from which to load extra 
properties. If not specified, this will look for conf/spark-defaults.conf.
   --extra-properties-file FILE     Path to an additional file(other than the 
default properties-file) to load extra properties. Properties in this file will 
override properties defined in the `--properties-file`.
   ```
   
   And for the K8S operator use cases, the additional properties file could be 
simply passed by `--extra-properties-file` instead of `--properties-file`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to