HyukjinKwon commented on code in PR #46819:
URL: https://github.com/apache/spark/pull/46819#discussion_r1623675471
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala:
##########
@@ -194,14 +195,16 @@ case class SessionHolder(userId: String, sessionId:
String, session: SparkSessio
*/
private[service] def interruptTag(tag: String): Seq[String] = {
val interruptedIds = new mutable.ArrayBuffer[String]()
+ val queries =
SparkConnectService.streamingSessionManager.getTaggedQuery(tag, session)
+ queries.foreach(_.query.stop())
Review Comment:
This one, I am not sure if we should just simply stop with blocking, which
is simple and straightforward but not sure if we should do something else,
@WweiL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
