juliuszsompolski commented on code in PR #46819:
URL: https://github.com/apache/spark/pull/46819#discussion_r1624132416
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala:
##########
@@ -194,14 +195,16 @@ case class SessionHolder(userId: String, sessionId:
String, session: SparkSessio
*/
private[service] def interruptTag(tag: String): Seq[String] = {
val interruptedIds = new mutable.ArrayBuffer[String]()
+ val queries =
SparkConnectService.streamingSessionManager.getTaggedQuery(tag, session)
+ queries.foreach(_.query.stop())
Review Comment:
Can stopping the queries be a blocking operation that takes some time / gets
stuck?
Before, interrupt would always be a fast non-blocking operation.
This may have significance if interrupt is called by client e.g. from a
catch while an application is being killed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
