WweiL commented on code in PR #46819:
URL: https://github.com/apache/spark/pull/46819#discussion_r1626398997
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala:
##########
@@ -179,12 +179,13 @@ case class SessionHolder(userId: String, sessionId:
String, session: SparkSessio
*/
private[service] def interruptAll(): Seq[String] = {
val interruptedIds = new mutable.ArrayBuffer[String]()
+ val operationsIds =
SparkConnectService.streamingSessionManager.cleanupRunningQueries(this)
executions.asScala.values.foreach { execute =>
if (execute.interrupt()) {
interruptedIds += execute.operationId
}
}
- interruptedIds.toSeq
+ interruptedIds.toSeq ++ operationsIds
Review Comment:
Also in classic spark is there such concept for batch queries?
In streaming a query is identified by (id, runId).
But we can also ask the user to keep a client side operation Id <->
streaming query map so it can be workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
