gengliangwang commented on code in PR #46980:
URL: https://github.com/apache/spark/pull/46980#discussion_r1639062248
##########
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala:
##########
@@ -71,8 +71,8 @@ class ExternalShuffleService(sparkConf: SparkConf,
securityManager: SecurityMana
if (localDirs.length >= 1) {
new File(localDirs.find(new File(_,
dbName).exists()).getOrElse(localDirs(0)), dbName)
} else {
- logWarning(s"'spark.local.dir' should be set first when we use db in " +
- s"ExternalShuffleService. Note that this only affects standalone
mode.")
+ logWarning(log"'spark.local.dir' should be set first when we use db in "
+
Review Comment:
Since there is not variables, let's just remove the `s`. No need to add `log`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
