asl3 commented on code in PR #46980:
URL: https://github.com/apache/spark/pull/46980#discussion_r1639939246
##########
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala:
##########
@@ -436,8 +436,8 @@ private[spark] class IndexShuffleBlockResolver(
if (checksumTmp.exists()) {
try {
if (!checksumTmp.delete()) {
- logError(s"Failed to delete temporary checksum file " +
- s"at ${checksumTmp.getAbsolutePath}")
+ logError(log"Failed to delete temporary checksum file at " +
+ log"${MDC(LogKeys.FILE_ABSOLUTE_PATH,
checksumTmp.getAbsolutePath)}")
Review Comment:
I see LogKey.scala has this key which is used in other files: `case object
FILE_ABSOLUTE_PATH extends LogKey`
should we migrate these other occurrences to `PATH` ? @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
