gengliangwang commented on code in PR #46980:
URL: https://github.com/apache/spark/pull/46980#discussion_r1639063076
##########
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala:
##########
@@ -503,8 +503,8 @@ class LogisticRegression @Since("1.2.0") (
tol, fitIntercept, maxBlockSizeInMB)
if (dataset.storageLevel != StorageLevel.NONE) {
- instr.logWarning(s"Input instances will be standardized, blockified to
blocks, and " +
- s"then cached during training. Be careful of double caching!")
+ instr.logWarning(log"Input instances will be standardized, blockified to
blocks, and " +
Review Comment:
let's just remove `s`
##########
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala:
##########
@@ -569,8 +569,8 @@ class LogisticRegression @Since("1.2.0") (
val isConstantLabel = histogram.count(_ != 0.0) == 1
if ($(fitIntercept) && isConstantLabel &&
!usingBoundConstrainedOptimization) {
- instr.logWarning(s"All labels are the same value and fitIntercept=true,
so the " +
- s"coefficients will be zeros. Training is not needed.")
+ instr.logWarning(log"All labels are the same value and
fitIntercept=true, so the " +
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
