gengliangwang commented on code in PR #46980:
URL: https://github.com/apache/spark/pull/46980#discussion_r1640645935
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -1562,9 +1561,10 @@ object CodeGenerator extends Logging {
private def logGeneratedCode(code: CodeAndComment): Unit = {
val maxLines = SQLConf.get.loggingMaxLinesForCodegen
if (Utils.isTesting) {
- logError(s"\n${CodeFormatter.format(code, maxLines)}")
+ logError(log"\n${MDC(LogKeys.FORMATTED_CODE,
+ CodeFormatter.format(code, MDC(LogKeys.MAX_LINES, maxLines)))}")
} else {
- logInfo(s"\n${CodeFormatter.format(code, maxLines)}")
+ logInfo(log"\n${MDC(LogKeys.FORMATTED_CODE, CodeFormatter.format(code,
maxLines))}")
Review Comment:
There was a discussion in this one. Let's avoid making the code as a key
since it can be very big.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
