HyukjinKwon commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1642396732


##########
python/pyspark/sql/tests/test_dataframe_query_context.py:
##########
@@ -41,7 +41,7 @@ def test_dataframe_query_context(self):
                 error_class="DIVIDE_BY_ZERO",
                 message_parameters={"config": '"spark.sql.ansi.enabled"'},
                 query_context_type=QueryContextType.DataFrame,
-                pyspark_fragment="divide",
+                fragment="__truediv__",

Review Comment:
   Ah, this is actually a bug fix. Previously it was (wrongly) checking the 
Scala side `DataFrameQueryContext.fragment` which had to be 
`DataFrameQueryContext.pysparkFragement`. Now it correctly checks 
`DataFrameQueryContext.pysparkFragement`.
   
   This is because we now merge `pysparkFragment` to `fragment` at 
`DataFrameQueryContext`, and it correctly tests the fragment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to