grundprinzip commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1641964734
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -407,3 +409,18 @@ message NamedArgumentExpression {
// (Required) The value expression of the named argument.
Expression value = 2;
}
+
+message Origin {
Review Comment:
My point is different. The callsite origin is something that is very generic
and very useful for relations as well. That the origin today is only applicable
to expressions is a side-effect of the implementation.
My goal is to have something like this
```
message Origin {
}
message Relation {
RelationCommon common = 1;
message RelationCommon {
Origin origin = 1;
}
}
message Expression {
ExpressionCommon common = 1;
message ExpressionCommon {
Origin origin = 1;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
