HyukjinKwon commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1641621467
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -407,3 +409,18 @@ message NamedArgumentExpression {
// (Required) The value expression of the named argument.
Expression value = 2;
}
+
+message Origin {
Review Comment:
Re: https://github.com/apache/spark/pull/46789#discussion_r1640210979 (I
think it's related).
The tricky thing is that `RelationCommon` binds to `Relation`. However, the
lazy evaluation tracking is based on where the expressions were created ,e.g.,
before we create a `DataFrame`.
If we can store the callside of the individual expressions at `source_info`
in `RelationCommon`, we could still be able to do it, but I think it's a little
bit awkward probably because the current implementation is specific to
`Expression`s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
