Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31390517
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,8 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+ require(indices.size == 0 || indices(0) >= 0,
--- End diff --
Just another conditional? seems vanishingly small compared to other work
done here. The current check assumes that it's in correct libsvm format and
that the indices are ordered ascending. The code doesn't actually rely on this
though and works even with missorted indices. However the current check
wouldn't work if "0:..." occurred later in the line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
