Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31390798
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,8 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+ require(indices.size == 0 || indices(0) >= 0,
--- End diff --
That's true.
And if we're adding the one-based check inside the iteration for each
indice-value pair, do you think we should check the ascending orders also?
I thought the original code avoid it intentionally for performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
