Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6538#discussion_r31394789
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -82,6 +82,8 @@ object MLUtils {
val value = indexAndValue(1).toDouble
(index, value)
}.unzip
+ require(indices.size == 0 || indices(0) >= 0,
--- End diff --
I think the sparse vector constructor doesn't verify its input since it's
created so frequently. But this seems like a reasonable place to check input,
when loading from libsvm. I was mistaken; this will silently fail if the libsvm
format is wrong and the indices aren't sorted. So I suppose your original check
is fine but if the ordering of the indices is also checked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
