cloud-fan commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1695368178
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -1657,7 +1657,7 @@ case class SubstringIndex(strExpr: Expression, delimExpr:
Expression, countExpr:
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
defineCodeGen(ctx, ev, (str, delim, count) =>
- CollationSupport.SubstringIndex.genCode(str, delim,
Integer.parseInt(count, 10), collationId))
Review Comment:
good catch! `count` is actually the generated java variable name of the
count value. We should not parse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
