wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1695520294
##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -424,6 +424,29 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
df.selectExpr("substring_index(a, '.', 2)"),
Row("www.apache")
)
+
+ val testTable = "test_substring_index"
+ // count is int
+ withTempPath { path =>
+ withTable(testTable) {
+ sql(s"CREATE TABLE $testTable (num int) USING parquet LOCATION
'${path.toURI.toString}'")
+ sql(s"INSERT INTO $testTable VALUES (1), (2), (3), (NULL)")
Review Comment:
I think it makes sense to test `null` values. The relevant user discovered
this problem through `null` values. In fact, when the `null` value is used as
count, the result is `null` and no exception will be thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
