wayneguow commented on code in PR #47481:
URL: https://github.com/apache/spark/pull/47481#discussion_r1696275785
##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -424,6 +424,14 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
df.selectExpr("substring_index(a, '.', 2)"),
Row("www.apache")
)
+
+ val testTable = "test_substring_index"
+ withTable(testTable) {
+ sql(s"CREATE TABLE $testTable (num int) USING parquet")
+ sql(s"INSERT INTO $testTable VALUES (1), (2), (3), (NULL)")
Review Comment:
Furthermore, It seems that there are some deficiencies in our current
testing mechanism related to built-in function with codegen, resulting in the
inability to cover these scenarios. I don’t know if the codegen part of other
functions can also be tested. If it is necessary to optimize the test coverage
of this area, I am willing to do it with your support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
