cloud-fan commented on code in PR #47485:
URL: https://github.com/apache/spark/pull/47485#discussion_r1696413905
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2111,7 +2111,7 @@
},
"INVALID_EMPTY_LOCATION" : {
"message" : [
- "The location name cannot be empty string, but `<location>` was given."
+ "The <locationKey> location cannot be empty string or null, but
`<locationValue>` was given."
Review Comment:
I thought we agreed to not change this error class... If we do want the
"locationKey", I'd prefer to use sub error conditions, as this is a known set
and may need to be translated when supporting international error messages.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2111,7 +2111,7 @@
},
"INVALID_EMPTY_LOCATION" : {
"message" : [
- "The location name cannot be empty string, but `<location>` was given."
+ "The <locationKey> location cannot be empty string or null, but
`<locationValue>` was given."
Review Comment:
I thought we agreed to not change this error condition... If we do want the
"locationKey", I'd prefer to use sub error conditions, as this is a known set
and may need to be translated when supporting international error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
