yaooqinn commented on code in PR #47485:
URL: https://github.com/apache/spark/pull/47485#discussion_r1698131660
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -134,9 +132,6 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
AlterDatabasePropertiesCommand(db, properties)
case SetNamespaceLocation(DatabaseInSessionCatalog(db), location) if
conf.useV1Command =>
- if (StringUtils.isEmpty(location)) {
Review Comment:
We extensively use `new Path` in the Spark repository. And here we rely on
its `toUri` for the entire string parsing. It's odd to distrust it for these
simple steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
