cloud-fan commented on code in PR #47485:
URL: https://github.com/apache/spark/pull/47485#discussion_r1697804012
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -134,9 +132,6 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
AlterDatabasePropertiesCommand(db, properties)
case SetNamespaceLocation(DatabaseInSessionCatalog(db), location) if
conf.useV1Command =>
- if (StringUtils.isEmpty(location)) {
Review Comment:
I'm a bit worried about the perf impact here, shouldn't we always check
empty string first then try creating URI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
