uros-db commented on code in PR #47503:
URL: https://github.com/apache/spark/pull/47503#discussion_r1698266469
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala:
##########
@@ -93,6 +94,10 @@ class HyperLogLogPlusPlusHelper(relativeSD: Double) extends
Serializable {
val value = dataType match {
case FloatType => FLOAT_NORMALIZER.apply(_value)
case DoubleType => DOUBLE_NORMALIZER.apply(_value)
+ case s: StringType => _value match {
+ case v: UTF8String => CollationFactory.getCollationKeyBytes(
+ v, s.collationId)
+ }
Review Comment:
we can either attempt something like this to avoid `match` in outer `case`:
```
case st: StringType if _value.isInstanceOf[UTF8String] =>
CollationFactory.getCollationKeyBytes(_value, st.collationId)
```
or catch any potential mismatches manually like so:
```
case st: StringType => _value match {
case val: UTF8String => CollationFactory.getCollationKeyBytes(val,
st.collationId)
case _ => _value
}
```
I'm leaning towards the first approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
