uros-db commented on code in PR #47503:
URL: https://github.com/apache/spark/pull/47503#discussion_r1698803908
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala:
##########
@@ -93,6 +94,8 @@ class HyperLogLogPlusPlusHelper(relativeSD: Double) extends
Serializable {
val value = dataType match {
case FloatType => FLOAT_NORMALIZER.apply(_value)
case DoubleType => DOUBLE_NORMALIZER.apply(_value)
+ case s: StringType if _value.isInstanceOf[UTF8String] =>
+ CollationFactory.getCollationKeyBytes(_value.asInstanceOf[UTF8String],
s.collationId)
Review Comment:
also, let's rethink what we're doing here so that we avoid regression for
`UTF8_BINARY`
if this piece of code should handle only non-binary collations, then let's
do:
```
case st: StringType if st.supportsBinaryEquality and
_value.isInstanceOf[UTF8String] =>
CollationFactory.getCollationKeyBytes(_value.asInstanceOf[UTF8String],
st.collationId)
```
so that the effective code path for `UTF8_BINARY` strings remains unchanged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
