uros-db commented on code in PR #47503:
URL: https://github.com/apache/spark/pull/47503#discussion_r1698270102
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -2319,6 +2319,57 @@ class CollationSQLExpressionsSuite
)
}
+ // scalastyle:off nonascii
+ test("approx_count_distinct returns correct with collation") {
Review Comment:
```suggestion
test("Support HyperLogLogPlusPlus expression with collation") {
```
let's follow the existing naming convention in this test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
