cloud-fan commented on code in PR #47501:
URL: https://github.com/apache/spark/pull/47501#discussion_r1701998020
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/parameters.scala:
##########
@@ -177,9 +177,17 @@ object BindParameters extends ParameterizedQueryProcessor
with QueryErrorsBase {
}
private def bind(p: LogicalPlan)(f: PartialFunction[Expression,
Expression]): LogicalPlan = {
- p.resolveExpressionsWithPruning(_.containsPattern(PARAMETER)) (f orElse {
- case sub: SubqueryExpression => sub.withNewPlan(bind(sub.plan)(f))
- })
+ p match {
+ case lp: PlanWithUnresolvedIdentifier =>
Review Comment:
Do we need to do it? `resolveExpressionsWithPruning` already recursively
transforms all the tree nodes and handles their expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
