cloud-fan commented on code in PR #47501: URL: https://github.com/apache/spark/pull/47501#discussion_r1703734011
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ########## @@ -68,23 +68,25 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper protected def withIdentClause( Review Comment: can we create an overload of this method that takes no `otherPlans`? Then we can reduce a lot of code changes of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
