mihailom-db commented on code in PR #47501:
URL: https://github.com/apache/spark/pull/47501#discussion_r1702122549
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala:
##########
@@ -37,7 +37,7 @@ class ResolveIdentifierClause(earlyBatches:
Seq[RuleExecutor[LogicalPlan]#Batch]
override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperatorsUpWithPruning(
_.containsAnyPattern(UNRESOLVED_IDENTIFIER,
UNRESOLVED_IDENTIFIER_WITH_CTE)) {
case p: PlanWithUnresolvedIdentifier if p.identifierExpr.resolved =>
-
executor.execute(p.planBuilder.apply(evalIdentifierExpr(p.identifierExpr)))
+
executor.execute(p.planBuilder.apply(evalIdentifierExpr(p.identifierExpr),
p.otherPlans))
Review Comment:
Yeah, that is true. That is why I tried to add a couple of tests with
interleaving of identifiers and non-identifiers. I can pass one more time
through AstBuilder, as I believe only InsertInto and one more LogicalPlans were
changed to have otherPlans as parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
