miland-db commented on code in PR #47423:
URL: https://github.com/apache/spark/pull/47423#discussion_r1711356753
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreterSuite.scala:
##########
@@ -206,11 +221,271 @@ class SqlScriptingInterpreterSuite extends QueryTest
with SharedSparkSession {
|END
|""".stripMargin
val expected = Seq(
- Seq.empty[Row], // declare var
- Seq.empty[Row], // set var
- Seq(Row(2)), // select
- Seq.empty[Row], // drop var - explicit
- Seq.empty[Row] // drop var - implicit
+ Array.empty[Row], // declare var
+ Array.empty[Row], // set var
+ Array(Row(2)), // select
+ Array.empty[Row], // drop var - explicit
+ )
+ verifySqlScriptResult(sqlScript, expected)
+ }
+
+ test("duplicate handler") {
Review Comment:
Any ideas for additional tests considering handlers is greatly appreciated.
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreterSuite.scala:
##########
@@ -206,11 +221,271 @@ class SqlScriptingInterpreterSuite extends QueryTest
with SharedSparkSession {
|END
|""".stripMargin
val expected = Seq(
- Seq.empty[Row], // declare var
- Seq.empty[Row], // set var
- Seq(Row(2)), // select
- Seq.empty[Row], // drop var - explicit
- Seq.empty[Row] // drop var - implicit
+ Array.empty[Row], // declare var
+ Array.empty[Row], // set var
+ Array(Row(2)), // select
+ Array.empty[Row], // drop var - explicit
+ )
+ verifySqlScriptResult(sqlScript, expected)
+ }
+
+ test("duplicate handler") {
Review Comment:
Any idea for additional tests considering **handlers** is greatly
appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
