davidm-db commented on code in PR #47423:
URL: https://github.com/apache/spark/pull/47423#discussion_r1713615148
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -82,6 +84,23 @@ singleStatement
: (statement|setResetStatement) SEMICOLON* EOF
;
+conditionValue
+ : stringLit
+ | multipartIdentifier
+ ;
+
+conditionValueList
+ : ((conditionValues+=conditionValue (COMMA
conditionValues+=conditionValue)*) | SQLEXCEPTION | NOT FOUND)
+ ;
+
+declareCondition
+ : DECLARE multipartIdentifier CONDITION (FOR stringLit)?
+ ;
+
+declareHandler
+ : DECLARE (CONTINUE | EXIT) HANDLER FOR conditionValueList (BEGIN
compoundBody END | statement)
Review Comment:
I think we should do `... (BEGIN compoundBody END | statement |
setStatementWithOptionalVarKeyword)` to completely match the behavior of `SET`
statements with compound bodies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
