davidm-db commented on code in PR #47423: URL: https://github.com/apache/spark/pull/47423#discussion_r1713476127
########## docs/sql-ref-ansi-compliance.md: ########## @@ -454,6 +454,7 @@ Below is a list of all the keywords in Spark SQL. |CONCATENATE|non-reserved|non-reserved|non-reserved| Review Comment: some of the keywords are missing here. also, check [parser PR](https://github.com/apache/spark/pull/46665) to see all places where I had to register/test/etc the addition of `BEGIN` keyword, you'll probably need to do the same... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
